Skip to content

fix(workflows): docs-preview and npm job #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 30, 2022
Merged

fix(workflows): docs-preview and npm job #5042

merged 4 commits into from
Mar 30, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 30, 2022

This includes the GITHUB_TOKEN on the docs-preview.yaml workflow, which should fix it on forks I believe. I also added a step to the npm job to comment instructions for how to test the PR locally.

Fixes N/A

@jsjoeio jsjoeio added the ci Issues related to ci label Mar 30, 2022
@jsjoeio jsjoeio self-assigned this Mar 30, 2022
@jsjoeio jsjoeio requested a review from a team March 30, 2022 00:16
@jsjoeio jsjoeio added this to the April 2022 milestone Mar 30, 2022
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

✨ code-server docs for PR #5042 is ready! It will be updated on every commit.

@jsjoeio jsjoeio temporarily deployed to npm March 30, 2022 00:21 Inactive
@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Merging #5042 (34d2555) into main (06e36b4) will not change coverage.
The diff coverage is n/a.

❗ Current head 34d2555 differs from pull request most recent head 8e8406f. Consider uploading reports for the commit 8e8406f to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5042   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          30       30           
  Lines        1683     1683           
  Branches      373      373           
=======================================
  Hits         1200     1200           
  Misses        413      413           
  Partials       70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e36b4...8e8406f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

✨ code-server dev build published to npm for PR #5042!

  • Last publish status: success
  • Commit: 8e8406f

To install in a local project, run:

npm install @coder/code-server-pr@5042

To install globally, run:

npm install -g @coder/code-server-pr@5042

code-asher
code-asher approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handy!

@jsjoeio jsjoeio temporarily deployed to npm March 30, 2022 16:37 Inactive
@jsjoeio jsjoeio merged commit 5341294 into main Mar 30, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-workflows branch March 30, 2022 17:47
@jsjoeio jsjoeio mentioned this pull request Mar 30, 2022
Merged
@jsjoeio jsjoeio modified the milestones: April 2022, 4.3.0 Apr 13, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
@jsjoeio @TinLe
fix(workflows): docs-preview and npm job (coder#5042)
2eba923 
* fix(ci): add GITHUB_TOKEN to docs-preview workflow

* feat(ci): comment npm dev build instructions on PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
ci Issues related to ci
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @code-asher